The sentence you provided is almost correct, but there is a small grammatical error. The correct version should be:
"He has been my best friend since childhood."
In this corrected sentence, the verb "has been" is used to indicate that the friendship started in the past and has continued until the present. This construction conveys the idea that the person has been the speaker's best friend since they were children.